Do not copy data before dropping (#28)

smol-rs · Oct 25, 2022 · 465e0e2 · 465e0e2
1 parent 5f80166
commit 465e0e2
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/once_cell.rs b/src/once_cell.rs
@@ -749,7 +749,11 @@ impl<T: fmt::Debug> fmt::Debug for OnceCell<T> {
 
 impl<T> Drop for OnceCell<T> {
     fn drop(&mut self) {
-        drop(self.take());
+        if State::from(*self.state.get_mut()) == State::Initialized {
+            // SAFETY: We know that the value is initialized, so it is safe to
+            // drop it.
+            unsafe { self.value.get().cast::<T>().drop_in_place() }
+        }
     }
 }