Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use once_cell from async-lock #95

Merged
merged 4 commits into from
Oct 25, 2022
Merged

Use once_cell from async-lock #95

merged 4 commits into from
Oct 25, 2022

Conversation

notgull
Copy link
Member

@notgull notgull commented Sep 28, 2022

Resolves #93 by using the OnceCell type found in async-lock. This type allows for blocking operations, just like the once_cell::Lazy type that was used earlier. In addition, async-lock does not bump our MSRV, while once_cell does.

This is a draft PR because smol-rs/async-lock#27 has not yet been released

@notgull
Copy link
Member Author

notgull commented Sep 28, 2022

Clippy failure is unrelated to this pull request.

@taiki-e
Copy link
Collaborator

taiki-e commented Oct 25, 2022

Published a new version of async-lock including smol-rs/async-lock#27.

@notgull notgull marked this pull request as ready for review October 25, 2022 16:42
@notgull
Copy link
Member Author

notgull commented Oct 25, 2022

Published a new version of async-lock including smol-rs/async-lock#27.

Alright, I've switched to using the released version of async-lock in this PR, and marked it ready for review.

src/reactor.rs Outdated Show resolved Hide resolved
@notgull notgull merged commit 6f3437d into master Oct 25, 2022
@notgull notgull deleted the once-cell-al branch October 25, 2022 16:57
@taiki-e taiki-e mentioned this pull request Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

async-io now fails to compile on 1.46
2 participants