Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop all elements when all receivers are dropped #86

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

drop all elements when all receivers are dropped #86

wants to merge 2 commits into from

Conversation

Zhou-Pixel
Copy link

  • drop all elements when all receivers are dropped
  • add test

@notgull
Copy link
Member

notgull commented Apr 14, 2024

Thanks!

I'm wondering if this would be better as a change on concurrent-queue instead of here. As in, close() does the drain automatically.

@taiki-e
Copy link
Collaborator

taiki-e commented Apr 14, 2024

Yeah, as said in #23 (comment), I think concurrent-queue is the right place to handle this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zhou-Pixel @notgull @taiki-e