Add defaults tests for restJson1 #2280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syall
requested changes
May 13, 2024
|
@syall Alex made the changes while I am away. Please re-review. |
cmoher
requested review from
milesziemer and
syall
and removed request for
alextwoods and
syall
milesziemer
approved these changes
May 29, 2024
|
Thank you! |
syall
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Add defaults tests for restJson1 similar to AwsJson1_0 and CBOR
Testing
In smithy-ruby, not sure how to test here.
Links
n/a
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.