Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Smithy Formatter To Gradle Tasks #2231

Open
0xjjoyy opened this issue Apr 8, 2024 · 2 comments
Open

Add Smithy Formatter To Gradle Tasks #2231

0xjjoyy opened this issue Apr 8, 2024 · 2 comments
Labels
bug This issue is a bug.

Comments

@0xjjoyy
Copy link
Contributor

0xjjoyy commented Apr 8, 2024

When contributing it's easier if there is a gradle task that can take care of formatting the Smithy files according to the project's desired format, such as empty line at EOF.

Doing a clean checkout and running the gradle tasks doesn't show any Smithy file formatter

./gradlew tasks

Please add the Smithy File formatter plugin to this project so it'll be easier and faster to make pull requests and contributions.

@0xjjoyy 0xjjoyy changed the title Add Smithy Formatter To Tasks Add Smithy Formatter To Gradle Tasks Apr 8, 2024
@JordonPhillips JordonPhillips added feature-request A feature should be added or improved. bug This issue is a bug. and removed feature-request A feature should be added or improved. labels Apr 23, 2024
@JordonPhillips
Copy link
Contributor

The gradle plugin already runs a formatter automatically.... or it's supposed to. Specifically the task is smithyFormat. It doesn't seem to be doing much though....

@JordonPhillips
Copy link
Contributor

Ah it seems we just have it disabled on a number of projects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug.
Projects
None yet
Development

No branches or pull requests

2 participants