Remove ignoreUnsupportedConstraintTraits from integration test models
#2516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that constraint traits are supported in server SDKs (with some corner case caveats, see #1401), we can remove `ignoreUnsupportedConstraintTraits` from the codegen config of the integration test models.
|
Worth implementing a check in |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
hlbarber
approved these changes
Apr 3, 2023
jjant
approved these changes
Apr 3, 2023
…-traits-from-integration-test-models
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
david-perez
deleted the
davidpz/remove-ignore-unsupported-constraint-traits-from-integration-test-models
branch
david-perez
added a commit
that referenced
this pull request
Apr 4, 2023
Now that constraint traits are supported in server SDKs (with some corner case caveats, see #1401), this flag will almost always be useless for those early adopters of constraint traits. It is thus convenient to inform the user that they should remove it. See #2516 (comment).
This was referenced Apr 4, 2023
Draft
unexge
pushed a commit
that referenced
this pull request
Apr 24, 2023
…ls (#2516) * Remove `ignoreUnsupportedConstraintTraits` from integration test models Now that constraint traits are supported in server SDKs (with some corner case caveats, see #1401), we can remove `ignoreUnsupportedConstraintTraits` from the codegen config of the integration test models. * Bring back ignoreUnsupportedConstraintTraits in RestJsonValidation model
rcoh
pushed a commit
that referenced
this pull request
Apr 24, 2023
…ls (#2516) * Remove `ignoreUnsupportedConstraintTraits` from integration test models Now that constraint traits are supported in server SDKs (with some corner case caveats, see #1401), we can remove `ignoreUnsupportedConstraintTraits` from the codegen config of the integration test models. * Bring back ignoreUnsupportedConstraintTraits in RestJsonValidation model
david-perez
added a commit
that referenced
this pull request
May 30, 2023
Now that constraint traits are supported in server SDKs (with some corner case caveats, see #1401), this flag will almost always be useless for those early adopters of constraint traits. It is thus convenient to inform the user that they should remove it. See #2516 (comment). ## Checklist <!--- If a checkbox below is not applicable, then please DELETE it rather than leaving it unchecked --> - [x] I have updated `CHANGELOG.next.toml` if I made changes to the smithy-rs codegen or runtime crates ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that constraint traits are supported in server SDKs (with some
corner case caveats, see
#1401), we can remove
ignoreUnsupportedConstraintTraitsfrom the codegen config of theintegration test models.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.