Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @length-constrained collection shapes whose members are not constrained #2103

Commits on Dec 14, 2022

  1. Fix @length-constrained collection shapes whose members are not con…

    …strained
    
    The generated code these should have emitted was fixed in #2085 (it's
    bug number 2), but code generation is still crashing because the call to
    calculate the inner constraint violation symbol is performed _before_
    checking that the collection's member can reach a constrained shape.
    
    The test that #2085 added in `constraints.smithy`:
    
    ```smithy
    @Length(max: 69)
    list LengthList {
        member: ConB
    }
    ```
    
    was not exercising what it should have, since `ConB`, is its name hints
    at, is a constrained structure shape.
    david-perez committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    093dd12 View commit details
    Browse the repository at this point in the history
  2. Add changelog entry

    david-perez committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    430291d View commit details
    Browse the repository at this point in the history
  3. Merge remote-tracking branch 'upstream/main' into davidpz/fix-length-…

    …constrained-shapes-whose-members-are-not-constrained
    david-perez committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    6256685 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. Merge branch 'main' into davidpz/fix-length-constrained-shapes-whose-…

    …members-are-not-constrained
    jjant committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    66afe38 View commit details
    Browse the repository at this point in the history