Add new service builder codegen #1693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlbarber
force-pushed
the
harryb/service-builder-codegen
branch
from
c7006d4
to
d3d6880
Compare
added 24 commits
September 5, 2022 14:18
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
david-perez
approved these changes
Sep 9, 2022
| override fun routerConstruction(service: ServiceShape, operationValues: Iterable<Writable>, model: Model): Writable = writable { | ||
| val allOperationShapes = allOperationShapes(service, model) | ||
|
|
||
| // TODO(restore): This causes a panic: "symbol visitor should not be invoked in service shapes" |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
2 tasks
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#1679
Description
ServerProtocolinterface to allow for server side protocol specific methods.ServerOperationGenerator, which generates a ZST and implementsOperationShapeon it.ServerServiceGeneratorV2, which generates the service newtype around a router and a service builder.hiddenargument toRustModulewhich allows modules to be marked with#[doc(hidden)].BuildModifiertrait to provide a common interface for extending service builders.Upgradabletrait to simplifying bounds when upgrading from anOperationto a HTTP service.FromRequest,FromParts, andIntoResponseimplementations.RoutingServiceaccept general body typesBfor the inner serviceshttp::Response<B>.Notes
operation_shape.rsandservice.rs. These are both marked as#[doc(hidden)]for now.OperationRegistryBuilderandRouter#1707from_request/into_responsemethods #1706unchecked_buildermethod to the service builder #1705