Migrate from structopt to clap v3
#1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`clap` v3 added support for a `structopt`-like parser derive usage. `structopt` is now in maintenance mode (https://docs.rs/structopt/latest/structopt/#maintenance); it is recommended to migrate to `clap`. Structs to parse CLI arguments have been renamed to `Args` for consistency.
|
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
|
Rust Wrk benchmark report:Duration: 90 sec, Connections: 32, Threads: 2
|
jdisanti
approved these changes
Apr 1, 2022
| /// The path to the smithy-rs repo folder. | ||
| #[structopt(long, parse(from_os_str))] | ||
| #[clap(long, parse(from_os_str))] |
There was a problem hiding this comment.
I'm not 100% on this, but the parse(from_os_str) might not be needed on the PathBufs anymore.
There was a problem hiding this comment.
AFAICS they're still needed to parse non-UTF-8 paths clap-rs/clap#3496.
| @@ -50,7 +50,7 @@ impl Opt { | |||
| } | |||
|
|
|||
| fn main() -> anyhow::Result<()> { | |||
| let opt = Opt::from_args().validate()?; | |||
| let opt = Args::parse().validate()?; | |||
There was a problem hiding this comment.
It looks like CI is failing since the Docker image tests that all the tools are in the right place by calling them with their --version flag, and I guess structopt must have been giving us that flag for free.
There was a problem hiding this comment.
Thanks! Fixed in 5365a83
|
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
|
Rust Wrk benchmark report:Duration: 90 sec, Connections: 32, Threads: 2
|
…-`structopt`-to-`clap`-v3
david-perez
force-pushed
the
davidpz-migrate-from-`structopt`-to-`clap`-v3
branch
from
c9e8835
to
959fc45
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. Rust Wrk benchmark report:Duration: 90 sec, Connections: 32, Threads: 2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clapv3 added support for astructopt-like parser derive usage.structoptis now in maintenance mode(https://docs.rs/structopt/latest/structopt/#maintenance); it is
recommended to migrate to
clap.Structs to parse CLI arguments have been renamed to
Argsforconsistency.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.