Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OperationRegistryBuilder and Router #1707

Closed
hlbarber opened this issue Sep 5, 2022 · 0 comments · Fixed by #2161
Closed

Remove OperationRegistryBuilder and Router #1707

hlbarber opened this issue Sep 5, 2022 · 0 comments · Fixed by #2161
Labels
server Rust server SDK

Comments

@hlbarber
Copy link
Contributor

hlbarber commented Sep 5, 2022

The conclusion of Service Builder Improvements is the removal of the original service builder, OperationRegistryBuilder, along with it's output, Router.

A list of chores which should be done during the removal:

  • Remove all Router associated code, and promote the protocol specific routers code to a more accessible module.
  • Remove existing from_request/into_response methods #1706, this can be done prior to the removal and blocks the further steps.
  • Remove rust-runtime/inlineable/src/server_operation_handler_trait.rs.
  • Cleanup kotlin/software/amazon/smithy/rust/codegen/server/smithy/generators/ServerServiceGenerator.kt and integrate it with kotlin/software/amazon/smithy/rust/codegen/server/smithy/generators/ServerServiceGeneratorV2.kt.
  • Remove kotlin/software/amazon/smithy/rust/codegen/server/smithy/generators/ServerOperationHandlerGenerator.kt.
@hlbarber hlbarber changed the title Remove of OperationRegistryBuilder and Router machinery Remove of OperationRegistryBuilder and Router Sep 5, 2022
@hlbarber hlbarber changed the title Remove of OperationRegistryBuilder and Router Remove OperationRegistryBuilder and Router Sep 6, 2022
@jdisanti jdisanti added the server Rust server SDK label Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
server Rust server SDK
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants