Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #639: Disable pre-compilation for Go 1.16+ #640

Merged
merged 1 commit into from Oct 21, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion web/server/system/shell_1_16.go
Expand Up @@ -3,5 +3,8 @@
package system

func compile(directory, gobin, tagsArg string) Command {
return NewCommand(directory, gobin, "test", tagsArg)
// Don't pre-compile on 1.16
// TODO(iannucci): rework the whole compilation feature to compile all
// test binaries up front in a single `go` command.
return Command{}
}