Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove md5 modifier from debug.tpl #871

Merged
merged 2 commits into from Apr 30, 2023
Merged

Remove md5 modifier from debug.tpl #871

merged 2 commits into from Apr 30, 2023

Conversation

j-applese3d
Copy link
Contributor

Replaced with a regular function call.
See #813

@j-applese3d
Remove md5 modifier from debug.tpl
33e048e 
Replaced with a regular function call. 
See smarty-php#813
@wisskid
Copy link
Contributor

wisskid commented Apr 4, 2023

This changes the syntax, but not the dependency. It will still fail in future Smarty versions.

@LDerkzenSawiday LDerkzenSawiday mentioned this pull request Apr 7, 2023
Closed
@j-applese3d
Copy link
Contributor Author

I have the same question as LDerkzenSawiday. I thought #813 says that |<phpfunction> was being removed, not the ability to use PHP functions altogether...

Nevertheless, I have changed it so md5 is now called by Smarty_Internal_Debug->display_debug rather than within the template.

@wisskid wisskid merged commit 19df91b into smarty-php:master Apr 30, 2023
10 checks passed
@wisskid wisskid mentioned this pull request Apr 30, 2023
Closed
@j-applese3d j-applese3d deleted the j-applese3d-patch-1 branch May 1, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@j-applese3d @wisskid