Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple operators in math equations #708

Merged
merged 2 commits into from Jan 17, 2022
Merged

Support multiple operators in math equations #708

merged 2 commits into from Jan 17, 2022

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Jan 17, 2022

Fixes #702.

@caugner caugner marked this pull request as draft January 17, 2022 11:40
caugner
caugner commented Jan 17, 2022
View reviewed changes
Copy link
Contributor Author

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO Add test case to https://github.com/smarty-php/smarty/blob/master/tests/UnitTests/TemplateSource/ValueTests/Math/MathTest.php.

@caugner caugner marked this pull request as ready for review January 17, 2022 11:47
@caugner
Copy link
Contributor Author

caugner commented Jan 17, 2022

@wisskid Please have a look at this PR if you can. 😃

@caugner caugner changed the title fix(math): fix equation regexp Support multiple operators in math equations Jan 17, 2022
@caugner caugner mentioned this pull request Jan 17, 2022
Closed
@wisskid wisskid merged commit 059bea2 into smarty-php:master Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Smarty 4.0.2 Warning: math: illegal characters
2 participants
@caugner @wisskid