Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#623 Static return type in docblocks; for better IDE support chaining #627

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#623 Static return type in docblocks; for better IDE support chaining #627

wants to merge 1 commit into from

Conversation

blaaat
Copy link

@blaaat blaaat commented Jan 6, 2021

see #623

@wisskid
Copy link
Contributor

wisskid commented Jul 16, 2022

@blaaat Wouldn't @return $this be more appropriate here?

@wisskid wisskid added the waiting Waiting for answer label Jul 16, 2022
@blaaat
Copy link
Author

blaaat commented Aug 8, 2022 •
edited

@wisskid I don't think so; static is a PHP8+ return type; which could be added as regular return type when php7 support is dropped.

@wisskid
Copy link
Contributor

wisskid commented Sep 12, 2022

But we're not dropping php7 support, right?

@blaaat
Copy link
Author

blaaat commented Oct 31, 2022

But we're not dropping php7 support, right?

This is just a doc block; so it's not dropping php7 support.

@wisskid wisskid removed the waiting Waiting for answer label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@blaaat @wisskid