Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw SmartyException when setting caching attributes for cacheable plugin #573

Merged
merged 3 commits into from Apr 13, 2020
Merged

Throw SmartyException when setting caching attributes for cacheable plugin #573

merged 3 commits into from Apr 13, 2020

Conversation

wisskid
Copy link
Contributor

@wisskid wisskid commented Feb 20, 2020

As compiling this would fail.

Fixes #457

@wisskid wisskid requested a review from uwetews February 20, 2020 22:50
@wisskid wisskid merged commit 4f89f6d into master Apr 13, 2020
@wisskid wisskid deleted the bugfix/caching_attributes_and_cacheable_plugin branch April 13, 2020 20:33
@wisskid wisskid restored the bugfix/caching_attributes_and_cacheable_plugin branch August 6, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uwetews uwetews Awaiting requested review from uwetews

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom plugin invocation compiles into garbage
1 participant
@wisskid