Skip to content

Commit

Permalink
Remove unused attributes from config_load
Browse files Browse the repository at this point in the history
fixes #993
  • Loading branch information
wisskid committed Apr 23, 2024
1 parent 8d53d3c commit 8dafcf4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
Expand Up @@ -9,7 +9,6 @@
|----------------|----------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| file | Yes | The name of the config file to include |
| section | No | The name of the section to load |
| scope | no | How the scope of the loaded variables are treated, which must be one of local, parent or global. local means variables are loaded into the local template context. parent means variables are loaded into both the local context and the parent template that called it. global means variables are available to all templates. |


## Examples
Expand Down
8 changes: 3 additions & 5 deletions src/Compile/Tag/ConfigLoad.php
Expand Up @@ -43,15 +43,15 @@ class ConfigLoad extends Base {
* @var array
* @see BasePlugin
*/
protected $optional_attributes = ['section', 'scope'];
protected $optional_attributes = ['section'];

/**
* Attribute definition: Overwrites base class.
*
* @var array
* @see BasePlugin
*/
protected $option_flags = ['nocache', 'noscope'];
protected $option_flags = [];

/**
* Compiles code for the {config_load} tag
Expand All @@ -66,9 +66,7 @@ public function compile($args, \Smarty\Compiler\Template $compiler, $parameter =
{
// check and get attributes
$_attr = $this->getAttributes($compiler, $args);
if ($_attr['nocache'] === true) {
$compiler->trigger_template_error('nocache option not allowed', null, true);
}

// save possible attributes
$conf_file = $_attr['file'];
$section = $_attr['section'] ?? 'null';
Expand Down

0 comments on commit 8dafcf4

Please sign in to comment.