Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Symfony 5 compatibility #19

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Fix Symfony 5 compatibility #19

merged 1 commit into from
Nov 11, 2020

Conversation

kumy
Copy link
Contributor

@kumy kumy commented Nov 11, 2020 •
edited by glensc

Updates to return int in execute() for Symfony 5 compatiblity.

Fixes #18
Refs:

@kumy
Fix smarty-gettext#18: return int in execute()
9247edb 
Here is a simple fix that bypass the issue reported in smarty-gettext#18
@kumy kumy mentioned this pull request Nov 11, 2020
Closed
@glensc glensc changed the title Fix #18: return int in execute() Fix Symfony 5 compatibility Nov 11, 2020
@glensc glensc merged commit cb0dc95 into smarty-gettext:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return value of "SmartyGettext\Console\Command\Extract::execute()" must be of the type int, "null" returned
2 participants
@kumy @glensc