This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
Fix vulnerability CVE-2018-3728 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patches vulnerability CVE-2018-3728
|
Coverage remained the same at 87.862% when pulling 670b11b on armstnp:fix/vuln-CVE-2018-3728 into 75ee1bd on smartsheet-platform:master. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping
request 2.54.0dependency to the latest stable versionrequest 2.85.0. This bumps its vulnerable descendant dependencyhoekto a patched version that covers the CVE.While the CVE recommended path is to use
hoek 5.0.3, but the issue is stated to have been confirmed fixed inhoek 4.2.1, which is what therequest 2.85.0package uses. See: request#2926