TECH-437 Lazy Evaluation #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so they can be lazy evalued
rraub
requested review from
esvinson,
matthew-kerle,
smartryanstewart and
magreenbaum
|
Credo disables this on elixir >= 1.7. Patch notes from Credo v1.0.3: PR for Reference: rrrene/credo#638 These should already be lazy. |
|
Dang! how did I miss that!? https://github.com/elixir-lang/elixir/blob/v1.7/CHANGELOG.md#other-logger-improvements |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wrap log formatting in functions so they can be lazy evaluated
Credo style guide: https://github.com/rrrene/credo/blob/master/lib/credo/check/warning/lazy_logging.ex
Should be no noticeable change, except saving some cpu cycles when the log level is set higher than debug.