-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New NovaPoshta Adapter 1.0.0 #2294
base: develop
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this PR! Referring to #2293 for the changeset issues
packages/core/legos/package.json
Outdated
"@chainlink/reduce-adapter": "workspace:*", | ||
"@chainlink/renvm-address-set-adapter": "workspace:*", | ||
"@chainlink/rocket-pool-adapter": "workspace:*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are being erroneously removed. Let's add them back.
packages/core/legos/tsconfig.json
Outdated
{ | ||
"path": "../../non-deployable/reduce" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
@@ -0,0 +1,43 @@ | |||
{ | |||
"name": "@chainlink/novaposhta-adapter", | |||
"version": "1.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to start it on 0.0.0, and make a changeset with a "major" version bump, which will make this 1.0.0 when released.
@@ -0,0 +1,13 @@ | |||
{ | |||
"$id": "https://external-adapters.chainlinklabs.com/schemas/example-source-adapter.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"$id": "https://external-adapters.chainlinklabs.com/schemas/example-source-adapter.json", | |
"$id": "https://external-adapters.chainlinklabs.com/schemas/novaposhta-adapter.json", |
APIEndpoint, | ||
} from '@chainlink/ea-bootstrap' | ||
import { makeConfig } from './config' | ||
import * as endpoints from './endpoint' // The endpoints must be exported as shown in endpoint/index.ts for README generation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import * as endpoints from './endpoint' // The endpoints must be exported as shown in endpoint/index.ts for README generation. | |
import * as endpoints from './endpoint' |
"number": "59000869676636" | ||
}] | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1 @@ | |||
Tests that run the adapter and send an end to end request using live API endpoints. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove this file
Tests that run the adapter and send an end to end request using mocked API endpoints. | ||
|
||
See `packages/source/curve/test/integration` and `packages/composite/synth-index/test/integration` for reference. The integration tests are used for the example input/outputs during README generation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this file
packages/tsconfig.test.json
Outdated
{ | ||
"path": "./scripts/src/generate-readme/test/integration/readme-test-adapter/tsconfig.test.json" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add this back in
const customError = (data: ResponseSchema) => data.success === false | ||
|
||
export const description = | ||
'Get shipment status by tracking number (https://developers.novaposhta.ua).' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you maybe add a link to where the different tracking status codes are explained?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@boxhock thank you very much, you showed in great detail what needs to be fixed.
I will take all the changes.
Please, if I merge branches incorrectly, let me know.
Description
NovaPoshta Adapter for tracking parcels.
Steps to Test
$ yarn test packages/sources/novaposhta/test/unit/tracking.test.ts PASS packages/sources/novaposhta/test/unit/tracking.test.ts Test Suites: 1 passed, 1 total Tests: 1 passed, 1 total Snapshots: 0 total Time: 1.672 s
Quality Assurance
<ADAPTER_PACKAGE>/schemas/env.json
and<ADAPTER_PACKAGE>/README.md
infra-k8s
configuration file.feature/x
,chore/x
,release/x
,hotfix/x
,fix/x
) or is created from Clubhouse/Shortcut