Page tabs component #1780
Merged
Page tabs component #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
khadni
requested review from
dwightjl,
aelmanaa and
thedriftofwords
as code owners
thedriftofwords
approved these changes
May 30, 2024
There was a problem hiding this comment.
Visually LGTM and nicely done!
There's a slow (~3 seconds) load when you first click an anchor link to a subsection of the page, and after that, navigating to subsequent anchor links is faster. Not going to block PR on this slight performance issue since I don't know if others are seeing it; worth looking into for a follow-up fix.
dwightjl
approved these changes
May 31, 2024
dwightjl
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.