replace geth import for patched websocket client #4984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
jmank88
commented
Sep 9, 2021
jmank88
force-pushed
the
bug/ch16033-patched-geth-websocket
branch
3 times, most recently
from
b9c0e0f
to
cfff421
Compare
jmank88
commented
Sep 9, 2021
jmank88
force-pushed
the
bug/ch16033-patched-geth-websocket
branch
from
cfff421
to
8d36a87
Compare
jmank88
force-pushed
the
bug/ch16033-patched-geth-websocket
branch
from
8d36a87
to
3f85b45
Compare
jmank88
commented
Sep 9, 2021
| @@ -85,3 +85,6 @@ require ( | |||
| // If that happens to get released in a 3.X.X version, we can add a constraint to our go.mod | |||
| // for it. If its in 4.X.X, then we need all our transitive deps to upgrade to it. | |||
| replace github.com/dgrijalva/jwt-go => github.com/form3tech-oss/jwt-go v3.2.1+incompatible | |||
|
|
|||
| // severed-websocket-1.10.8 | |||
| replace github.com/ethereum/go-ethereum => github.com/smartcontractkit/go-ethereum v1.10.9-0.20210909134823-a177d470d620 | |||
There was a problem hiding this comment.
smartcontractkit/go-ethereum@a177d47
Until geth includes ethereum/go-ethereum#23556
jmank88
force-pushed
the
bug/ch16033-patched-geth-websocket
branch
from
3f85b45
to
f6a580f
Compare
j16r
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.clubhouse.io/chainlinklabs/story/16033/chainlink-doesn-t-reconnect-when-the-websocket-connection-hangs