KS-128: Implement remove DONs in capability registry #13220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cds95
requested review from
archseer,
bolekk,
patrick-dowell and
a team
as code owners
cds95
commented
May 16, 2024
|
|
||
| // DON config count starts at index 1 | ||
| if (don.configCount == 0) revert DONDoesNotExist(donId); | ||
| delete s_dons[donId]; |
There was a problem hiding this comment.
I think we can get away with not cleaning up the nested mappings. Resetting configCount to 0 will return empty values in the getter functions. Test.
cds95
commented
May 16, 2024
| @@ -559,6 +567,20 @@ contract CapabilityRegistry is OwnerIsCreator, TypeAndVersionInterface { | |||
| emit DONAdded(id, isPublic); | |||
| } | |||
|
|
|||
| /// @notice Removes DONs from the Capability Registry | |||
| /// @param donIds The IDs of the DON to be removed | |||
| function removeDONs(uint32[] calldata donIds) external onlyOwner { | |||
There was a problem hiding this comment.
We should probably update addDON to addDONs later in a followup PR
There was a problem hiding this comment.
I think it would make that function extremely complex.
|
DeividasK
approved these changes
May 16, 2024
archseer
approved these changes
May 16, 2024
cds95
merged commit 2e698a0
into
use-encode-instead-of-encode-packed-capability-id
117 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.