Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TT-1160] fix clean up order #13205

Merged
merged 2 commits into from
May 15, 2024
Merged

[TT-1160] fix clean up order #13205

merged 2 commits into from
May 15, 2024

Conversation

Tofel
Copy link
Contributor

@Tofel Tofel commented May 15, 2024

No description provided.

lukaszcl
lukaszcl reviewed May 15, 2024
View reviewed changes
Copy link
Collaborator

@lukaszcl lukaszcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tofel lgtm. Btw, can you check if coverage reports are still generated in the CI workflow?

@lukaszcl
Copy link
Collaborator

@Tofel lgtm. Btw, can you check if coverage reports are still generated in the CI workflow?

@Tofel I just checked them in the last build and they look fine 👍

lukaszcl
lukaszcl previously approved these changes May 15, 2024
View reviewed changes
@Tofel Tofel marked this pull request as ready for review May 15, 2024 15:54
@Tofel Tofel requested a review from a team as a code owner May 15, 2024 15:54
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
1 New issue
0 Fixed issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@Tofel Tofel added this pull request to the merge queue May 15, 2024
Merged via the queue into develop with commit dbc971b May 15, 2024
107 checks passed
@Tofel Tofel deleted the tt_1160_logging_after_test_ended branch May 15, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tateexon tateexon tateexon approved these changes

@lukaszcl lukaszcl lukaszcl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Tofel @lukaszcl @tateexon