-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple static workflow graph validation from execution state #13201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I see you updated files related to
|
bolekk
previously approved these changes
May 15, 2024
ettec
previously approved these changes
May 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
May 15, 2024
HenryNguyen5
requested changes
May 15, 2024
krehermann
force-pushed
the
ks-207/common-wf-spec
branch
from
May 15, 2024 22:05
e3329c0
to
a5b7194
Compare
HenryNguyen5
approved these changes
May 15, 2024
Quality Gate passedIssues Measures |
bolekk
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change pre-sages refactoring the workflow validation into
chainlink-common
for use by CLO.The point of the change is to decouple the notion of valid yaml (that forms a graph) from the notion of an executable workflow whose steps have mutable step that are updated by the engine when it's executed.
To achieve that, we introduce a
StaticWorkflow
that is only the intermediate representation from parsing YAML into a valid graph.Given this graph, we convert it to the pre-existing notion of a workflow.
The next change will be to move the
StaticWorkflow
intochainlink-common
, which is the reason that it's public to start.