Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-1151] use latest stable version of evm node implementations #954

Merged
merged 5 commits into from
May 17, 2024

Conversation

Tofel
Copy link
Contributor

@Tofel Tofel commented May 14, 2024

  • don't do fake gas estimation for zero address if evm node is not geth

Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes focus on updating Ethereum client versions to their latest or more stable releases for multiple clients such as Besu, Erigon, Geth, and Nethermind within a test environment setup. Additionally, there's an enhancement in how gas estimations are handled and a minor correction in a test case to improve clarity and testing accuracy.

What

  • docker/test_env/besu_base.go

    • Updated defaultBesuEth2Image to "hyperledger/besu:24.5.1". This change ensures the use of the latest Besu version for Ethereum 2.0 simulations, likely bringing in performance improvements and bug fixes.
    • Added networkConfig.SimulationType = "Besu" to clearly indicate the Ethereum client type in simulations, enhancing debuggability and logging.
  • docker/test_env/besu_test.go

    • Modified error message in TestBesuEth2 from "Could connect to the evm client" to "Could connect Besu", and added a new line at the end of the file. These changes improve the error message's clarity when connections to the Besu client fail during tests.
  • docker/test_env/erigon_base.go

    • Updated defaultErigonEth2Image to "thorax/erigon:v2.59.3". This change updates the Erigon container to a more stable version for Ethereum 2.0 simulations, addressing specific issues like broken gas estimations.
    • Added networkConfig.SimulationType = "Erigon" to mark the simulation type explicitly, aiding in identifying the Ethereum client in use during tests.
  • docker/test_env/geth_base.go

    • Updated defaultGethEth2Image to "ethereum/client-go:v1.14.3". This update moves the Geth client to a newer version for Ethereum 2.0 simulations, likely incorporating new features and fixes.
    • Added networkConfig.SimulationType = "Geth" to label the type of Ethereum client being simulated, improving the ability to filter logs and debug issues.
  • docker/test_env/nethermind_base.go

    • Updated defaultNethermindEth2Image to "nethermind/nethermind:1.26.0". This update ensures the use of an updated Nethermind version for Ethereum 2.0 simulations, reflecting the latest improvements and bug resolutions.
    • Added networkConfig.SimulationType = "Nethermind" to specifically denote the client type in network simulations, facilitating easier identification during testing phases.
  • docker/test_env/test_utils.go

    • Modified sendAndCompareBalances function to include From address and Value in ethereum.CallMsg for gas estimations, and reorganized the code for clarity. This adjustment ensures more accurate gas estimations by considering the transaction's value and sender, leading to more reliable test outcomes.

…gas estimation for zero address if evm node is not geth
@Tofel Tofel marked this pull request as ready for review May 17, 2024 14:49
@Tofel Tofel requested review from sebawo and a team as code owners May 17, 2024 14:49
docker/test_env/besu_test.go Outdated Show resolved Hide resolved
Co-authored-by: Adam Hamrick <adam.hamrick@smartcontract.com>
@cl-sonarqube-production
Copy link

@Tofel Tofel merged commit 3083a59 into main May 17, 2024
19 of 20 checks passed
@Tofel Tofel deleted the tt_1151_add_besu_back_use_latest_versions branch May 17, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants