Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add context #567

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

add context #567

wants to merge 1 commit into from

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Jan 12, 2024 •
edited

@jmank88 jmank88 mentioned this pull request Jan 12, 2024
Draft
@jmank88 jmank88 force-pushed the BCF-2887-context-propagation branch 2 times, most recently from 34b233c to 370f7a5 Compare January 13, 2024 00:02
@jmank88 jmank88 force-pushed the BCF-2887-context-propagation branch from 370f7a5 to 648abe8 Compare January 13, 2024 00:19
@jmank88 jmank88 force-pushed the BCF-2887-context-propagation branch from 648abe8 to 5f6ba60 Compare January 13, 2024 01:01
@jmank88 jmank88 force-pushed the BCF-2887-context-propagation branch from 5f6ba60 to 0cf7d82 Compare January 13, 2024 01:18
@jmank88 jmank88 force-pushed the BCF-2887-context-propagation branch from 0cf7d82 to e7a2c9a Compare January 13, 2024 19:34
@jmank88 jmank88 force-pushed the BCF-2887-context-propagation branch from e7a2c9a to fc2300c Compare January 13, 2024 21:41
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 33.3% 33.3% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

@jmank88 jmank88 force-pushed the BCF-2887-context-propagation branch from 9b02127 to 9c339b6 Compare March 24, 2024 21:06
@jmank88 jmank88 force-pushed the BCF-2887-context-propagation branch from 9c339b6 to 83e23c0 Compare March 25, 2024 13:23
krehermann
krehermann reviewed Mar 25, 2024
View reviewed changes
integration-tests/go.mod Outdated
@@ -2,6 +2,10 @@ module github.com/smartcontractkit/chainlink-solana/integration-tests

go 1.21.7

replace github.com/smartcontractkit/tdh2/go/ocr2/decryptionplugin => github.com/jmank88/tdh2/go/ocr2/decryptionplugin v0.0.0-20240321204202-bf6e0344b64b
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't have auth to push a branch to tdh2 so this was required to use my personal fork of that repo until the PR is merged.

krehermann
krehermann reviewed Mar 25, 2024
View reviewed changes
integration-tests/go.mod Outdated
@@ -2,6 +2,10 @@ module github.com/smartcontractkit/chainlink-solana/integration-tests

go 1.21.7

replace github.com/smartcontractkit/tdh2/go/ocr2/decryptionplugin => github.com/jmank88/tdh2/go/ocr2/decryptionplugin v0.0.0-20240321204202-bf6e0344b64b

replace github.com/smartcontractkit/tdh2/go/tdh2 => github.com/jmank88/tdh2/go/tdh2 v0.0.0-20240321204202-bf6e0344b64b
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this?

@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

aalu1418
aalu1418 reviewed Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@aalu1418 aalu1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good to me!

integration-tests/go.mod Outdated Show resolved Hide resolved
pkg/solana/monitor/balance.go Show resolved Hide resolved
pkg/solana/relay.go
Comment on lines +71 to +80
func (r *Relayer) GetChainStatus(ctx context.Context) (relaytypes.ChainStatus, error) {
return r.chain.GetChainStatus(ctx)
}

func (r *Relayer) ListNodeStatuses(ctx context.Context, pageSize int32, pageToken string) (stats []relaytypes.NodeStatus, nextPageToken string, total int, err error) {
return r.chain.ListNodeStatuses(ctx, pageSize, pageToken)
}

func (r *Relayer) Transact(ctx context.Context, from, to string, amount *big.Int, balanceCheck bool) error {
return r.chain.Transact(ctx, from, to, amount, balanceCheck)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breaking interface changes?

will probably want to get everything running between this PR and core PR before merging this one (trying to reduce the amount of time something would be broken)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I wanted to get these clean and collapse them all quickly, but we're clogged up on tdh2 now unfortunately. I will wait to open this until it is ready.

@jmank88 jmank88 force-pushed the BCF-2887-context-propagation branch from 83e23c0 to 64c0495 Compare April 25, 2024 11:00
@jmank88 jmank88 force-pushed the BCF-2887-context-propagation branch from 64c0495 to b77da61 Compare April 25, 2024 17:17
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
33.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krehermann krehermann krehermann left review comments

@aalu1418 aalu1418 aalu1418 left review comments

@patrickhuie19 patrickhuie19 Awaiting requested review from patrickhuie19

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmank88 @krehermann @aalu1418