tx simulation + config diff + minor refactor #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RodrigoAD
reviewed
Mar 21, 2022
gauntlet/packages/gauntlet-solana-contracts/src/commands/contracts/ocr2/proposePayees.ts
Outdated
Show resolved
Hide resolved
gauntlet/packages/gauntlet-solana-contracts/src/commands/contracts/ocr2/proposePayees.ts
Outdated
Show resolved
Hide resolved
gauntlet/packages/gauntlet-solana-contracts/src/commands/contracts/ocr2/proposeConfig.ts
Outdated
Show resolved
Hide resolved
...tlet/packages/gauntlet-solana-contracts/src/commands/contracts/ocr2/proposeOffchainConfig.ts
Show resolved
Hide resolved
RodrigoAD
reviewed
Mar 22, 2022
...et/packages/gauntlet-solana-contracts/src/commands/contracts/ocr2/proposal/acceptProposal.ts
Show resolved
Hide resolved
RodrigoAD
reviewed
Mar 23, 2022
|
|
||
| const ocr2 = getContract(CONTRACT_LIST.OCR_2, '') | ||
| const address = ocr2.programId.toString() | ||
| this.program = this.loadProgram(ocr2.idl, address) |
There was a problem hiding this comment.
Can you move this into buildCommand?
RodrigoAD
reviewed
Mar 23, 2022
gauntlet/packages/gauntlet-solana-contracts/src/commands/contracts/ocr2/proposePayees.ts
Outdated
Show resolved
Hide resolved
RodrigoAD
reviewed
Mar 23, 2022
gauntlet/packages/gauntlet-solana-contracts/src/commands/contracts/ocr2/proposePayees.ts
Outdated
Show resolved
Hide resolved
RodrigoAD
reviewed
Mar 23, 2022
gauntlet/packages/gauntlet-solana-contracts/src/commands/contracts/ocr2/proposePayees.ts
Outdated
Show resolved
Hide resolved
RodrigoAD
previously approved these changes
Mar 24, 2022
|
Issue created here - #263 |
…und printDiff object comparison bug
RodrigoAD
force-pushed
the
feature/tx-simulation-config-diff
branch
from
f251f04
to
6e3bf7f
Compare
RodrigoAD
force-pushed
the
feature/tx-simulation-config-diff
branch
from
6e3bf7f
to
9bee832
Compare
RodrigoAD
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.