Ownership commands for every program #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RodrigoAD
commented
Jan 14, 2022
| const tx = await program.rpc.acceptOwnership({ | ||
| accounts: { | ||
| // Store contract expects an store account instead of a state acc | ||
| ...(contractId === CONTRACT_LIST.STORE && { store: state }), |
There was a problem hiding this comment.
@archseer Seems like the store contract expects a different account name than the rest. Should we have same interface on every program?
(https://github.com/smartcontractkit/chainlink-solana/blob/develop/contracts/programs/store/src/lib.rs#L133)
There was a problem hiding this comment.
Yeah we could do that, I kept the name different initially since there were some calls where both store and ocr2 state had to be passed but in that case it's probably better to use store_state/ocr2_state.
archseer
approved these changes
Jan 18, 2022
RodrigoAD
force-pushed
the
gauntlet-general-transfer-ownership
branch
from
74dd5b2
to
c403fa0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.