Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create semver-compare github action #94

Merged
merged 17 commits into from
Jun 14, 2023
Merged

Conversation

chainchad
Copy link
Collaborator

Use to compare two semver strings.

@chainchad chainchad force-pushed the feature/re-1537-semver-compare branch 3 times, most recently from 5d3f8ce to b01b5bd Compare June 13, 2023 21:40
@chainchad chainchad force-pushed the feature/re-1537-semver-compare branch from b01b5bd to 2356866 Compare June 13, 2023 22:51
Copy link
Collaborator

@tateexon tateexon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to add a couple tests to verify the functionality and run those tests on prs to make sure the functionality doesn't get broken in the future?

@chainchad
Copy link
Collaborator Author

@tateexon good call. I refactored this a bit, added tests, and CI. Largely modeled after https://github.com/actions/typescript-action/.

@chainchad chainchad requested a review from tateexon June 14, 2023 15:20
Copy link
Collaborator

@tateexon tateexon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems your workflow is invalid
Invalid workflow file: .github/workflows/semver-compare-check-dist.yaml#L1
you may only define one of paths and paths-ignore for a single event

@chainchad
Copy link
Collaborator Author

Thanks @tateexon - should be fixed.

@chainchad chainchad merged commit bc6e3b5 into main Jun 14, 2023
4 checks passed
@chainchad chainchad deleted the feature/re-1537-semver-compare branch June 14, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants