-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create semver-compare github action #94
Conversation
5d3f8ce
to
b01b5bd
Compare
b01b5bd
to
2356866
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to add a couple tests to verify the functionality and run those tests on prs to make sure the functionality doesn't get broken in the future?
@tateexon good call. I refactored this a bit, added tests, and CI. Largely modeled after https://github.com/actions/typescript-action/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems your workflow is invalid
Invalid workflow file: .github/workflows/semver-compare-check-dist.yaml#L1
you may only define one of paths
and paths-ignore
for a single event
Thanks @tateexon - should be fixed. |
Use to compare two semver strings.