Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA-138 part 2 - Remove Requirement For Ginkgo Instal #52

Merged
merged 5 commits into from Nov 17, 2022
Merged

QA-138 part 2 - Remove Requirement For Ginkgo Instal #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a5832d8
Make ginkgo not required
tateexon Nov 17, 2022
10301a1
Use new setup
tateexon Nov 17, 2022
4de6e32
testing
tateexon Nov 17, 2022
b3f1289
bump
tateexon Nov 17, 2022
c987cf4
use new version
tateexon Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 2 additions & 3 deletions chainlink-testing-framework/run-tests/action.yml
View file
Open in desktop
Expand Up @@ -15,7 +15,6 @@ inputs:
test_download_ginkgo_command:
required: false
description: The command to download Ginkgo
default: make install
cl_repo:
required: false
description: The Chainlink ecr repository to use
Expand Down Expand Up @@ -84,7 +83,7 @@ runs:
steps:
# Setup Tools and libraries
- name: Setup environment
uses: smartcontractkit/chainlink-github-actions/chainlink-testing-framework/setup-run-tests-environment@v2.0.25
uses: smartcontractkit/chainlink-github-actions/chainlink-testing-framework/setup-run-tests-environment@v2.0.28
with:
test_download_vendor_packages_command: ${{ inputs.test_download_vendor_packages_command }}
test_download_ginkgo_command: ${{ inputs.test_download_ginkgo_command }}
Expand Down Expand Up @@ -152,7 +151,7 @@ runs:
path: ${{ inputs.artifacts_location }}
- name: cleanup
if: always()
uses: smartcontractkit/chainlink-github-actions/chainlink-testing-framework/cleanup@v2.0.25
uses: smartcontractkit/chainlink-github-actions/chainlink-testing-framework/cleanup@v2.0.28
with:
triggered_by: ${{ inputs.triggered_by }}
should_cleanup: ${{ inputs.should_cleanup }}
7 changes: 5 additions & 2 deletions chainlink-testing-framework/setup-run-tests-environment/action.yml
View file
Open in desktop
Expand Up @@ -8,7 +8,6 @@ inputs:
test_download_ginkgo_command:
required: false
description: The command to download Ginkgo
default: make install
go_mod_path:
required: false
description: The go.mod file path
Expand Down Expand Up @@ -51,6 +50,10 @@ runs:
- name: Install Ginkgo CLI
shell: bash
run: |
if [[ -z "${{ inputs.test_download_ginkgo_command }}" ]]; then
# short-circuit when we don't want to install ginkgo
exit 0
fi
CHECK=$(which ginkgo || true)
if [[ -z "${CHECK}" ]]; then
${{ inputs.test_download_ginkgo_command }}
Expand Down Expand Up @@ -86,7 +89,7 @@ runs:
shell: bash
run: |
go version
ginkgo version
[[ ! -z "${{ inputs.test_download_ginkgo_command }}" ]] && ginkgo version
aws --version
kubectl version
helm version
Expand Down