Output logs when failures happen but not in a test #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tateexon
force-pushed
the
handle_go_test_failure_with_no_failed_tests
branch
from
0a5e632
to
a325e60
Compare
tateexon
force-pushed
the
handle_go_test_failure_with_no_failed_tests
branch
from
a325e60
to
bb58e66
Compare
| testResults.filter(testResult => { | ||
| if (testResult.Action === 'fail') { | ||
| if (testResult.Test) { | ||
| names.push(testResult.Test) | ||
| } else { | ||
| // we got a failure without a test failure | ||
| packageFailure = true |
There was a problem hiding this comment.
@tateexon I'm wondering if this case is expected and if we'll always fall through to this case?
When I was reviewing the output for the flakey test runner I put together, I had to handle both cases because:
- if a test fails, you'll always get output saying the package failed
- a package could fail without a test failing (eg. in the case of the test spinning off a goroutine and panicing -- go can't trace the goroutine back to its originating test so just fails the package IIRC).
There was a problem hiding this comment.
I am handling this above in the main function https://github.com/smartcontractkit/chainlink-github-actions/pull/104/files#diff-c7f06bc3c11b303038bdf62606b11c5bbbb495340e36f01702aaf4b39cebe347R29-R38
There was a problem hiding this comment.
I think my comment is the problem here, will update the comment to make more sense.
There was a problem hiding this comment.
The comment in code has been updated to make more sense.
cedric-cordenier
approved these changes
Aug 4, 2023
tateexon
force-pushed
the
handle_go_test_failure_with_no_failed_tests
branch
from
b7bb85a
to
9ccb362
Compare
kalverra
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a corner case in go test results where the test run can fail but there are no test specified failures in the logs. We don't have a great way to pull out what caused it so in this case we just print out all the output.