Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing print of lint errors in golangci-lint action #246

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Fixing print of lint errors in golangci-lint action #246

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2c08f8d
fix/lint-action: trying json lint artifact to make parsing file name …
patrickhuie19 Nov 16, 2023
1360345
fix/lint-action: trying lint error
patrickhuie19 Nov 16, 2023
35d1e14
fix/lint-action: trying w/ enable flag removed in gh action
patrickhuie19 Nov 16, 2023
201ac53
fix/lint-action: parity with make target
patrickhuie19 Nov 16, 2023
8183f3f
fix/lint-action: using multiple output format feature
patrickhuie19 Nov 16, 2023
e8e1e1a
try/lint: trying intentional lint error for sonar
patrickhuie19 Nov 16, 2023
094dede
fix/lint-action: reverting test lint failures
patrickhuie19 Nov 16, 2023
a371de9
fix/lint-action: minor refactoring
patrickhuie19 Nov 17, 2023
e01c809
fix/lint-actions: adding sonar.projectName and fixing typo
patrickhuie19 Nov 17, 2023
afeedce
Update Sonar download artefacts specs
chudilka1 Nov 20, 2023
61060a8
Merge branch 'main' into fix/lint-action
patrickhuie19 Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 12 additions & 7 deletions .github/workflows/golangci_lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,22 @@ jobs:
- name: Install golangci-lint
run: curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.54.2

# go.work makes it necessary to run linter manually
- name: Run golangci-lint
run: find . -name "go.mod" -execdir $(go env GOPATH)/bin/golangci-lint run --enable=gofmt --tests=false --exclude-use-default --timeout=5m0s --out-format checkstyle:golangci-lint-report.xml \;
run: docker run --rm -v ${{ github.workspace }}:/app -w /app golangci/golangci-lint:v1.54.2 golangci-lint run --max-issues-per-linter 0 --max-same-issues 0 --out-format checkstyle:golangci-lint-results.xml,json:golangci-lint-results.json || true

- name: Check golangci-lint report for errors
run: find . -name "golangci-lint-report.xml" -exec grep "error" {} + && exit 1 || true
run: |
if jq -e '.Issues | length > 0' golangci-lint-results.json; then
echo "Lint issues found:"
jq '.Issues[] | "\(.FromLinter): \(.Pos.Filename):\(.Pos.Line) \(.Text)"' golangci-lint-results.json
exit 1
else
echo "No issues found"
fi

- name: Upload golangci-lint report
- name: Upload golangci-lint JSON report
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still upload xml and download it as XML to sonar, I am not sure it will be correct to tie it to JSON

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix the typo, my bad. The artifact that is uploaded is in xml format.

if: always()
uses: actions/upload-artifact@v3
with:
name: golangci-lint-report
patrickhuie19 marked this conversation as resolved.
Show resolved Hide resolved
path: |
./golangci-lint-report.xml
path: ./golangci-lint-results.xml
2 changes: 1 addition & 1 deletion .github/workflows/sonar-scan.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ jobs:
shell: bash
run: |
echo "sonarqube_coverage_report_paths=$(find -type f -name '*coverage.out' -printf "%p,")" >> $GITHUB_OUTPUT
echo "sonarqube_golangci_report_paths=$(find -type f -name 'golangci-lint-report.xml' -printf "%p,")" >> $GITHUB_OUTPUT
echo "sonarqube_golangci_report_paths=$(find -type f -name 'golangci-lint-results.xml' -printf "%p,")" >> $GITHUB_OUTPUT

- name: SonarQube Scan
if: always()
Expand Down
2 changes: 1 addition & 1 deletion sonar-project.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ sonar.projectKey=smartcontractkit_chainlink-common
sonar.sources=.
chudilka1 marked this conversation as resolved.
Show resolved Hide resolved

# Full exclusions from the static analysis
sonar.exclusions=**/mocks/**/*, **/testdata/**/*, **/script/**/*, **/generated/**/*, **/fixtures/**/*, **/docs/**/*, **/tools/**/*, **/*.pb.go, **/*report.xml, **/*.txt, **/*.abi, **/*.bin
sonar.exclusions=**/mocks/**/*, **/testdata/**/*, **/script/**/*, **/generated/**/*, **/fixtures/**/*, **/docs/**/*, **/tools/**/*, **/*.pb.go, **/*results, **/*.txt, **/*.abi, **/*.bin
# Coverage exclusions
sonar.coverage.exclusions=**/*_test.go

Expand Down