Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support token prices in commit plugin #862

Merged
merged 1 commit into from
May 16, 2024
Merged

Support token prices in commit plugin #862

merged 1 commit into from
May 16, 2024

Conversation

dimkouv
Copy link
Member

@dimkouv dimkouv commented May 15, 2024

Supporting token prices in commit plugin.

  • Config: Prices only for fee tokens, provided in plugin config.
  • Observation: Using token prices reader interface
  • Validations: Non dups / etc...
  • Consensus: Median

@dimkouv dimkouv requested a review from a team as a code owner May 15, 2024 21:28
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset.

@dimkouv dimkouv merged commit 5b03348 into ccip-develop May 16, 2024
77 of 78 checks passed
@dimkouv dimkouv deleted the dk/token-prices branch May 16, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makramkd makramkd makramkd approved these changes

@connorwstein connorwstein Awaiting requested review from connorwstein

@winder winder Awaiting requested review from winder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dimkouv @makramkd