Liquidity manager tokens and transfer tokens check #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you updated files related to |
amirylm
force-pushed
the
LM-103-rebalancer-tokens-and-transfer-tokens-check-missing
branch
from
cef2042
to
2f61c07
Compare
…r-tokens-check-missing
ogtownsend
approved these changes
May 15, 2024
…r-tokens-check-missing
ogtownsend
reviewed
May 15, 2024
Comment on lines
+164
to
+167
| l2Token, err := l2GatewayWrapper.CalculateL2TokenAddress(nil, l1Token) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("get local token from liquidityManager: %w", err) | ||
| } |
There was a problem hiding this comment.
This might change when we flatten everything and the LM is no longer powering a single i_localToken right? The call to l1Token, err := l1LiquidityManager.ILocalToken(nil) above might return a list of tokens
makramkd
approved these changes
May 16, 2024
…r-tokens-check-missing
amirylm
deleted the
LM-103-rebalancer-tokens-and-transfer-tokens-check-missing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
GetTransfers()functions (bridges), are lacking checks that the L1 and L2 liquidity manager tokens match the addresses provided asremoteTokenandlocalToken.Solution
Get liquidity managers token in bridge constructor and save for reuse, upon calls to
GetTransfer()use the address to compare withremoteTokenandlocalToken.