Use decimals to normalize aggregator prices #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarnaud
changed the title
dimkouv
approved these changes
May 16, 2024
| } | ||
| } | ||
| chainCalls := batchCallsPerChain[aggCfg.ChainID] | ||
| chainCalls.decimalCalls = append(chainCalls.decimalCalls, rpclib.NewEvmCall( |
There was a problem hiding this comment.
aggregator contract is one per token that's why we don't need to pass token address as a param, right?
There was a problem hiding this comment.
Indeed, the type AggregatorPriceConfig defines this chaindID/aggregatorAddress pair.
mateusz-sekara
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Aggregators may returns prices with various decimal settings, not always 18.
We need to normalize returned results to wei.
Solution
Use decimals call to the aggregator to know its format and perform conversion if needed (i.e. if decimals not already 18).