Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-OffRamp - upgradability handling #825

Merged
merged 4 commits into from
May 16, 2024

Conversation

elatoskinas
Copy link
Collaborator

@elatoskinas elatoskinas commented May 8, 2024

Motivation

Handles upgradability in the MultiOffRamp, and re-introduces pool tests for execution functions

Solution

  • Prevents on ramp / prev ramp updates
  • getSenderNonce returns prev ramp nonce

Out of scope for this PR:

  • ARL / MultiCommitStore integrations

@elatoskinas elatoskinas added the do not merge Do not merge at this time label May 8, 2024
Copy link
Contributor

github-actions bot commented May 8, 2024

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

@elatoskinas elatoskinas marked this pull request as ready for review May 8, 2024 10:45
Copy link
Contributor

github-actions bot commented May 8, 2024

LCOV of commit f0ecce1 during Solidity Foundry #4400

Summary coverage rate:
  lines......: 98.8% (1192 of 1207 lines)
  functions..: 96.3% (261 of 271 functions)
  branches...: 92.3% (480 of 520 branches)

Files changed coverage rate: n/a

@elatoskinas elatoskinas force-pushed the feat/multi-offramp-batch-execution branch from e5657f6 to 6ca6b86 Compare May 8, 2024 13:51
@elatoskinas elatoskinas requested a review from a team as a code owner May 8, 2024 13:51
@elatoskinas elatoskinas force-pushed the feat/multi-offramp-upgradability branch from 2999a5a to 5893c3b Compare May 8, 2024 13:59
Copy link
Contributor

github-actions bot commented May 8, 2024

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

Copy link
Contributor

github-actions bot commented May 9, 2024

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

Copy link
Contributor

github-actions bot commented May 9, 2024

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

@elatoskinas elatoskinas force-pushed the feat/multi-offramp-upgradability branch from bdbab75 to 2022c47 Compare May 14, 2024 12:17
Copy link
Contributor

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

1 similar comment
Copy link
Contributor

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

Base automatically changed from feat/multi-offramp-batch-execution to ccip-develop May 15, 2024 09:54
@elatoskinas elatoskinas force-pushed the feat/multi-offramp-upgradability branch from 2022c47 to a6c9562 Compare May 15, 2024 10:57
@elatoskinas elatoskinas removed the do not merge Do not merge at this time label May 15, 2024
@elatoskinas elatoskinas merged commit 288c09d into ccip-develop May 16, 2024
78 of 79 checks passed
@elatoskinas elatoskinas deleted the feat/multi-offramp-upgradability branch May 16, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants