Add calculating percentiles in testreport finalization #810
+52
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emate
force-pushed
the
emate/add-percentiles-calculation-for-ccip-tests
branch
from
01ba525
to
fa9ea49
Compare
AnieeG
reviewed
May 16, 2024
| Min float64 `json:"min_duration_for_successful_requests(s),omitempty"` | ||
| Max float64 `json:"max_duration_for_successful_requests(s),omitempty"` | ||
| Avg float64 `json:"avg_duration_for_successful_requests(s),omitempty"` | ||
| Percentiles map[float64]float64 `json:"percentiles,omitempty"` |
There was a problem hiding this comment.
is there a way to directly calculate percentile from grafana queries? I am doing the same for min, max and avg
There was a problem hiding this comment.
@AnieeG unfortunately, it's not possible in cases when the number of messages is larger than the limit for fetching log lines from Loki.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Calculate and report percentiles at the finalization of CCIP tests to cover cases where it's impossible to calculate them from Loki due to the max log lines fetch limit.
Solution
Gather all durations per phase within the
AggregatorMetricsand calculate percentiles at the finalization stage.