Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate manual execution threshold from oracle message visibility threshold. #770

Draft
wants to merge 11 commits into
base: ccip-develop
Choose a base branch
from
Draft

Separate manual execution threshold from oracle message visibility threshold. #770

wants to merge 11 commits into from

Conversation

dimkouv
Copy link
Member

@dimkouv dimkouv commented Apr 28, 2024 •
edited

Add a new offRamp offchainConfig field to know after what time the offchain code should stop attempting a ccip msg.

chainlink-common PR: smartcontractkit/chainlink-common#504

RensR added 2 commits May 3, 2024 15:46
@RensR
add test, gen wrappers
07f86b0
@RensR
Merge branch 'ccip-develop' into dk/msg-visibility-interval
e1192bc 
# Conflicts:
#	contracts/gas-snapshots/ccip.gas-snapshot
#	core/gethwrappers/ccip/generated/evm_2_evm_offramp/evm_2_evm_offramp.go
#	core/gethwrappers/ccip/generation/generated-wrapper-dependency-versions-do-not-edit.txt
@RensR RensR force-pushed the dk/msg-visibility-interval branch from 0a634b4 to e1192bc Compare May 3, 2024 13:49
@smartcontractkit smartcontractkit deleted a comment from github-actions bot May 3, 2024
@smartcontractkit smartcontractkit deleted a comment from github-actions bot May 3, 2024
@smartcontractkit smartcontractkit deleted a comment from github-actions bot May 3, 2024
@smartcontractkit smartcontractkit deleted a comment from github-actions bot May 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 3, 2024 •
edited

LCOV of commit abd2b10 during Solidity Foundry #4414

Summary coverage rate:
  lines......: 98.8% (1192 of 1207 lines)
  functions..: 96.3% (261 of 271 functions)
  branches...: 92.3% (480 of 520 branches)

Files changed coverage rate: n/a

RensR added 2 commits May 6, 2024 11:44
@RensR
backwards compatible with 1.2
77446d3
@RensR
Merge branch 'ccip-develop' into dk/msg-visibility-interval
0df945d 
# Conflicts:
#	contracts/gas-snapshots/ccip.gas-snapshot
#	core/gethwrappers/ccip/generation/generated-wrapper-dependency-versions-do-not-edit.txt
@smartcontractkit smartcontractkit deleted a comment from github-actions bot May 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

I see you added a changeset file but it does not contain a tag. Please edit the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions GitHub Actions
Copy link
Contributor

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

@github-actions GitHub Actions
Copy link
Contributor

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

@github-actions GitHub Actions
Copy link
Contributor

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dadaism dadaism dadaism left review comments

@RensR RensR RensR left review comments

@makramkd makramkd Awaiting requested review from makramkd makramkd will be requested when the pull request is marked ready for review makramkd is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dimkouv @dadaism @RensR