Ccip 2063 find tx from seqnum #724
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you updated files related to |
winder
requested changes
Apr 19, 2024
Comment on lines
+11
to
+13
| "github.com/ethereum/go-ethereum/accounts/abi/bind" | ||
| "github.com/ethereum/go-ethereum/common" | ||
| "github.com/ethereum/go-ethereum/ethclient" |
There was a problem hiding this comment.
I think the evm dependency is going away, it might be better to put this command in ccip-scripts
| seqNumsInput := flag.String("seqnums", "", "Enter sequence numbers separated by comma (e.g., 1,2,3)") | ||
| onRampAddress := flag.String("onRamp", "", "Enter on-ramp address") | ||
| startBlock := flag.Uint64("startblock", 0, "Enter start block as starting block num to look for txs") | ||
| rpcURL := flag.String("rpc", "", "Enter RPC endpoint") |
There was a problem hiding this comment.
You could also use chainID and resolve the URL with the environment variable.
Comment on lines
+80
to
+82
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Might be nice to print out if any were missing
Suggested change
| } | |
| } | |
| } | |
| } | |
| delete(seqNumbers, sendRequested.Event.Message.SequenceNumber) | |
| } | |
| } | |
| if len(seqNumbers) != 0 { | |
| log.Warnf("Unable to find some sequence numbers were not found: %v", maps.Keys(seqNumbers)) | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solution