Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fish shell auto-completion #708

Merged
merged 1 commit into from Jul 28, 2022
Merged

Add fish shell auto-completion #708

merged 1 commit into from Jul 28, 2022

Conversation

Delapouite
Copy link
Contributor

Hello

Name of feature:

Fish shell auto-completion

Pain or issue this feature alleviates:

The step CLI is already offering support for bash and zsh auto-completion, but fish was not provided yet.

Why is this important to the project (if not answered above):

To improve the user experience and improve discoverability of the tool.

Is there documentation on how to use this feature? If so, where?

step completion fish > ~/.config/fish/completions/step.fish

In what environments or workflows is this feature supported?

In what environments or workflows is this feature explicitly NOT supported (if any)?

Supporting links/other PRs/issues:

With the help of urfave/cli#848

Thank you!

@CLAassistant
Copy link

CLAassistant commented Jul 26, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Jul 26, 2022
Copy link
Contributor

@dopey dopey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dopey dopey merged commit ff5a58f into smallstep:master Jul 28, 2022
@Delapouite Delapouite deleted the fish branch July 28, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants