Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the SR-CP call that uses the context settings or MP-config settings #725

Merged
merged 1 commit into from Oct 12, 2021

Conversation

FroMage
Copy link
Contributor

@FroMage FroMage commented Oct 12, 2021

This is the equivalent of quarkusio/quarkus#19869 which we did for Quarkus.

It allows the user to get either scope-local context settings, or default to MP-config settings instead of the "all propagation" that was the case before. This allows users to override the context settings globally.

@FroMage
Copy link
Contributor Author

FroMage commented Oct 12, 2021

@jponge I think @Sanne needs this to be put in a release ASAP to get benchmarks running in the lab, so if you were planning a release soon, it could be considered? Thanks.

@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #725 (4b7ffde) into main (3a3e8c0) will increase coverage by 0.22%.
The diff coverage is 100.00%.

❗ Current head 4b7ffde differs from pull request most recent head 948c5eb. Consider uploading reports for the commit 948c5eb to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main     #725      +/-   ##
============================================
+ Coverage     89.81%   90.03%   +0.22%     
- Complexity     2984     2993       +9     
============================================
  Files           374      374              
  Lines         11789    11789              
  Branches       1478     1480       +2     
============================================
+ Hits          10588    10614      +26     
+ Misses          614      601      -13     
+ Partials        587      574      -13     
Impacted Files Coverage Δ
.../context/DefaultContextPropagationInterceptor.java 100.00% <100.00%> (ø)
.../mutiny/context/MutinyContextManagerExtension.java 100.00% <100.00%> (ø)
...lrye/mutiny/subscription/SerializedSubscriber.java 82.07% <0.00%> (-0.95%) ⬇️
...mallrye/mutiny/operators/multi/MultiFlatMapOp.java 86.15% <0.00%> (+1.23%) ⬆️
...erators/multi/builders/SerializedMultiEmitter.java 82.27% <0.00%> (+1.26%) ⬆️
...y/operators/multi/builders/IterableBasedMulti.java 84.04% <0.00%> (+2.12%) ⬆️
...java/io/smallrye/mutiny/helpers/Subscriptions.java 80.11% <0.00%> (+2.20%) ⬆️
...mallrye/mutiny/operators/multi/FlatMapManager.java 98.61% <0.00%> (+2.77%) ⬆️
...operators/multi/builders/CollectionBasedMulti.java 96.77% <0.00%> (+3.22%) ⬆️
...iny/operators/multi/builders/BaseMultiEmitter.java 83.33% <0.00%> (+4.16%) ⬆️
... and 1 more

@jponge
Copy link
Member

jponge commented Oct 12, 2021

Hi @FroMage, sure we can have a minor release "pretty soonish" 😉

@jponge jponge added the enhancement New feature or request label Oct 12, 2021
@jponge jponge added this to the 1.1.2 milestone Oct 12, 2021
@cescoffier cescoffier merged commit 8c8b6e0 into smallrye:main Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants