No need to release downstream subscriber references #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to have an interpretation of the RS TCK that it had to be null on cancellation to release the subscriber. It's actually not necessary (and NPE-prone) since operators are instantiated per-subscription, so the *publisher* does not actually keep references on cancelled subscribers. Fixes #705
Codecov Report
@@ Coverage Diff @@
## main #712 +/- ##
============================================
+ Coverage 89.94% 90.24% +0.29%
- Complexity 2985 2999 +14
============================================
Files 374 374
Lines 11791 11789 -2
Branches 1478 1480 +2
============================================
+ Hits 10606 10639 +33
+ Misses 609 586 -23
+ Partials 576 564 -12
|
|
Also waiting for a check of this branch from the reporter in #705 |
|
Perfect this fix solved the problem. Thanks! |
cescoffier
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to have an over interpretation of the RS TCK that downstream subscriber references had to be null on cancellation.
It's actually not necessary (and NPE-prone) since operators are instantiated per-subscription, so the publisher does not actually keep references on cancelled subscribers.
Fixes #705