Use the setup-java caching #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The caching uses actions/cache@v2 under-the-hood. This reduces our YAML debt.
Closed
cescoffier
approved these changes
Oct 4, 2021
| - uses: actions/checkout@v2 | ||
| - uses: actions/setup-java@v2 | ||
| name: set up jdk ${{matrix.java.version}} | ||
| with: | ||
| distribution: temurin | ||
| java-version: ${{matrix.java.version}} | ||
| cache: maven |
There was a problem hiding this comment.
It only works because we still compile our artifacts for Java 8, right?
There was a problem hiding this comment.
It caches the dependencies, not the produced artefacts
There was a problem hiding this comment.
It's actually the same as the old caching, except that the setup-java action nows manages the caching one.
Codecov Report
@@ Coverage Diff @@
## main #698 +/- ##
============================================
+ Coverage 90.07% 90.14% +0.06%
Complexity 2993 2993
============================================
Files 374 374
Lines 11791 11791
Branches 1480 1480
============================================
+ Hits 10621 10629 +8
+ Misses 600 594 -6
+ Partials 570 568 -2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The caching uses actions/cache@v2 under-the-hood.
This reduces our YAML debt.