Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UniToMultiPublisher race condition #691

Merged
merged 2 commits into from Sep 22, 2021
Merged

Fix UniToMultiPublisher race condition #691

merged 2 commits into from Sep 22, 2021

Conversation

jponge
Copy link
Member

@jponge jponge commented Sep 21, 2021

  • Protect UniToMultiPublisher from re-subscriptions when concurrent requests happen
  • Refactor concurrency management in UniToMultiPublisher

Fixes #689

@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #691 (3091418) into main (5a631a2) will increase coverage by 0.06%.
The diff coverage is 76.47%.

❗ Current head 3091418 differs from pull request most recent head 6550edd. Consider uploading reports for the commit 6550edd to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main     #691      +/-   ##
============================================
+ Coverage     89.91%   89.98%   +0.06%     
- Complexity     2978     2980       +2     
============================================
  Files           374      374              
  Lines         11764    11770       +6     
  Branches       1476     1478       +2     
============================================
+ Hits          10578    10591      +13     
+ Misses          608      604       -4     
+ Partials        578      575       -3     
Impacted Files Coverage Δ
...rye/mutiny/converters/uni/UniToMultiPublisher.java 86.84% <75.00%> (-0.66%) ⬇️
...subscription/SwitchableSubscriptionSubscriber.java 97.54% <100.00%> (+2.45%) ⬆️
...smallrye/mutiny/helpers/test/AssertSubscriber.java 90.22% <0.00%> (-1.51%) ⬇️
...perators/multi/processors/SerializedProcessor.java 87.12% <0.00%> (-1.00%) ⬇️
...operators/multi/builders/CollectionBasedMulti.java 93.54% <0.00%> (ø)
...mallrye/mutiny/operators/multi/MultiFlatMapOp.java 85.04% <0.00%> (+0.31%) ⬆️
...allrye/mutiny/operators/uni/UniAndCombination.java 89.53% <0.00%> (+1.16%) ⬆️
...erators/multi/builders/SerializedMultiEmitter.java 82.27% <0.00%> (+1.26%) ⬆️
...mallrye/mutiny/operators/multi/FlatMapManager.java 98.61% <0.00%> (+2.77%) ⬆️
... and 1 more

@jponge jponge marked this pull request as ready for review September 21, 2021 20:52
@jponge jponge added the bug Something isn't working label Sep 21, 2021
@jponge jponge added this to the 1.1.0 milestone Sep 21, 2021
@jponge jponge merged commit 2df1918 into main Sep 22, 2021
@jponge jponge deleted the bug/689 branch September 22, 2021 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi.createBy().repeating() doesn't like flatMap
2 participants