Commits on Dec 2, 2022

1. Fix class ordering when propagating type annotations …

   To propagate type annotations across nested classes, we sort the entire
   set of indexed classes so that outer classes come before inner classes.
   We don't really care about ordering between classes that are not enclosed
   in one another. In other words, if we consider the equivalence relation
   of "be enclosed in" (where we consider a class to be enclosed in itself,
   so that the relation is reflexive and hence indeed equivalence), we must
   only sort the equivalence classes of this relation, individually. That is,
   we define partial order on classes.
   
   However, to perform that sort, we use the sorting routine in the JDK, which
   uses the order defined by a `Comparator`, and that order must be total.
   In this commit, we define a total order between classes like so:
   
   1. For each pair of classes A and B:
   2. if A and B have the same name, they are considered equal;
   3. if A is enclosed in B, A is considered greater than B;
   4. if B is enclosed in A, A is considered less than B;
   5. otherwise, A and B are sorted lexicographically based on their name.
   
   The `Comparator` we use to sort the indexed classes implements this order.

   

   Ladicek committed Dec 2, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 751d90e
   • Browse repository at this point

   Copy the full SHA

   751d90e View commit details

   Browse the repository at this point in the history