Fix class ordering when propagating type annotations #290
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To propagate type annotations across nested classes, we sort the entire set of indexed classes so that outer classes come before inner classes. We don't really care about ordering between classes that are not enclosed in one another. In other words, if we consider the equivalence relation of "be enclosed in" (where we consider a class to be enclosed in itself, so that the relation is reflexive and hence indeed equivalence), we must only sort the equivalence classes of this relation, individually. That is, we define partial order on classes.
However, to perform that sort, we use the sorting routine in the JDK, which uses the order defined by a
Comparator
, and that order must be total. In this commit, we define a total order between classes like so:The
Comparator
we use to sort the indexed classes implements this order.Fixes #289