Server Logs Read Fix #417
Open
Server Logs Read Fix #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
live streaming -n 1000 is a good idea for plain file 50000 maybe is a good idea too |
mitya52
requested changes
May 10, 2024
mitya52
requested changes
May 10, 2024
Comment on lines
47
to
51
| for line in tailer.tail(open(right_file, 'r'), last_n_lines): | ||
| yield line + '\n' | ||
|
|
||
| if stream: | ||
| async for line in atail(right_file): # (line, from_file) |
There was a problem hiding this comment.
here we can loose some lines from working logs
There was a problem hiding this comment.
inthe case of streaming it should work exactly as
tail -n last_n_lines -f logfile
valaises
force-pushed
the
server_logs_reading_fix
branch
from
fd55311
to
0a797bc
Compare
|
doesn't work correctly with
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.