Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix esp32c3 in rust std compile error #4066

Closed
wants to merge 1 commit into from
Closed

Fix esp32c3 in rust std compile error #4066

wants to merge 1 commit into from

Conversation

zhangzqs
Copy link
Contributor

@zhangzqs zhangzqs commented Dec 2, 2023

No description provided.

@CLAassistant
Copy link

CLAassistant commented Dec 2, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@zhangzqs
fix esp32 std compile error
3b0120d 
fix mcu no_std compile error

update

fix

refactor
@zhangzqs zhangzqs mentioned this pull request Dec 2, 2023
Closed
@zhangzqs zhangzqs changed the title Fix esp-idf in rust std compile error Fix esp32 in rust std compile error Dec 2, 2023
@zhangzqs zhangzqs changed the title Fix esp32 in rust std compile error Fix esp32c3 in rust std compile error Dec 2, 2023
@hunger
Copy link
Member

hunger commented Dec 4, 2023

Would you mind signing the CLA? It's basically MIT-licensing your contribution for use in Slint.

@zhangzqs
Copy link
Contributor Author

zhangzqs commented Dec 4, 2023

Would you mind signing the CLA? It's basically MIT-licensing your contribution for use in Slint.

signed

@hunger
Copy link
Member

hunger commented Dec 4, 2023

Thank you!

The person with the best ESP32 knowledge will only be back by the end of the week. Sorry, I am afraid this will stay open for a couple of days.

@ogoffart
Copy link
Member

ogoffart commented Dec 8, 2023

Thanks a lot for your PR!

This change is unfortunate as it would "break" anyone using no_std and not enabling explicitly the critical_section feature in once_cell.

But it might be fixed by matklad/once_cell#251 which was released in once_cell 1.19.0 yesterday.
could you try doing cargo update to opdate once_cell and check if this PR is still necessary?

@ogoffart
Copy link
Member

I'm going to go ahead and close this PR since i think this is fixed with matklad/once_cell#251
Thanks anyway for making a pull request.

@ogoffart ogoffart closed this Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zhangzqs @CLAassistant @hunger @ogoffart