Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qt: do not wrap QPainter directly, but use a unique_ptr instead #1231

Merged
merged 1 commit into from May 5, 2022
Merged

Qt: do not wrap QPainter directly, but use a unique_ptr instead #1231

merged 1 commit into from May 5, 2022

Conversation

ogoffart
Copy link
Member

@ogoffart ogoffart commented May 5, 2022

Because QPainter can't be relocated.

Fixes #1230

@ogoffart ogoffart requested review from tronical and hunger May 5, 2022 10:17
hunger
hunger approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@hunger hunger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So basically all QObjects need to be held as a pointer in Rust? Interesting.

@ogoffart
Copy link
Member Author

ogoffart commented May 5, 2022

So basically all QObjects need to be held as a pointer in Rust? Interesting

Yes (but QPainter is not a QObject)

@ogoffart ogoffart merged commit 0c19751 into master May 5, 2022
@ogoffart ogoffart deleted the olivier/fix-1230 branch May 5, 2022 11:50
ogoffart added a commit that referenced this pull request May 9, 2022
@ogoffart
Native style: Fix crash when opening a combobox
afed211 
Bug introduced by #1231
@ogoffart ogoffart mentioned this pull request May 9, 2022
Merged
ogoffart added a commit that referenced this pull request May 9, 2022
@ogoffart
Native style: Fix crash when opening a combobox
226ceca 
Bug introduced by #1231
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tronical tronical tronical approved these changes

@hunger hunger hunger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

crash when rawing opacity layer in release mode with the Qt backend
3 participants
@ogoffart @tronical @hunger